refactor(crashlytics): migrate to TypeScript. #8814
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
russellwheatley
changed the title
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
It is still a bit shocking to see typescript happening, in the meta sense. Amazing.
Two thoughts - one about shipping all source and one about common tsconfig, I'd class those as meaningful but also easy for a think + fix. Curious what you think on them
Otherwise a +1
| "files": [ | ||
| "lib/modular", | ||
| "dist", | ||
| "!**/__tests__", | ||
| "!**/__fixtures__", | ||
| "!**/__mocks__" | ||
| ], |
There was a problem hiding this comment.
In an open-source context, with a semi-frequent need for "patch-package" I was semi-frequently annoyed when typescript packages didn't ship with all the source needed to recreate the build after doing a yarn inside their module inside node_modules
Is there any reason not to include all the source files? It appears some are missing in the event someone wanted to patch the typescript and transpile it post-install vs patching the generated blobbage
"include": ["lib/**/*", "../app/lib/internal/global.d.ts"],
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
this appears to be 100% boilerplate, any reason not to have a common definition in app and use extends to centralize management of these configs?
mikehardy
added
the
Workflow: Waiting for User Response
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter